agent_kube: Add request_client.merge_environment_settings to api_server.py#767
Closed
schmidax wants to merge 1 commit intoCheckmk:release/2.3.0p20from
Closed
agent_kube: Add request_client.merge_environment_settings to api_server.py#767schmidax wants to merge 1 commit intoCheckmk:release/2.3.0p20from
schmidax wants to merge 1 commit intoCheckmk:release/2.3.0p20from
Conversation
This commit fixes the kube_agent as in this Werk: https://checkmk.com/werk/16892 The only difference is that the problem here is not establishing a connection with the agent, but with the Kubernetes API.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
Contributor
|
Hi schmidax, thank you for your submission. Sadly, we can't accept this contribution. The reason is that it would cause a regression affecting the proxy options. This is also the case for the original change we made ourselves, see https://checkmk.com/werk/17563 I have implemented an alternative fix in https://checkmk.com/werk/17562 . With this Werk, the bug you reported is resolved. Thanks again, kind regards, Sol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
After upgrading from version 2.2.0p32cee to 2.3.0p19cee I had a similar problem as described in the following work:
https://checkmk.com/werk/16892
Here only the problem with connecting to the agent was fixed, but not the one for connecting to the Kubernetes API.
Bug reports
CMK version: 2.3.0p19
OS version: Ubuntu Server 20.04
Kubernetes: RKE2(v1.30.5+rke2r1)
Error message: cmk.special_agents.agent_kube.ClusterConnectionError: Failed to establish a connection at URL https:///version
Output of “~/share/check_mk/agents/special/agent_kube --debug ”:
Proposed changes
In this fix for the Kubernetes API, the same solution is used as for the connection establishment with the agent in a customized version.