Skip to content

Commit

Permalink
test(quick_setup): do not assert anything
Browse files Browse the repository at this point in the history
If the call does not raise an error, then it validated correctly. That
way we can drop the type ignores.

Change-Id: I2ea7b9f8211f4d5818dde8b4f183719814df00ac
  • Loading branch information
logan-connolly committed Feb 28, 2025
1 parent 306ddd3 commit a8b37f1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/unit/cmk/gui/quick_setup/test_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
pytest.param((2, 1), id="second value is less than first"),
],
)
def test_validate_throttling_values(payload: tuple[int, ...]) -> None:
assert validate_throttling_values(payload) is None # type: ignore[func-returns-value]
def test_validate_throttling_values_valid(payload: tuple[int, ...]) -> None:
validate_throttling_values(payload)


@pytest.mark.parametrize(
Expand All @@ -47,8 +47,8 @@ def test_validate_throttling_values_raises(payload: tuple[int, ...]) -> None:
pytest.param((1, 1), id="values are the same"),
],
)
def test_validate_notification_count_values(payload: tuple[int, ...]) -> None:
assert validate_notification_count_values(payload) is None # type: ignore[func-returns-value]
def test_validate_notification_count_values_valid(payload: tuple[int, ...]) -> None:
validate_notification_count_values(payload)


@pytest.mark.parametrize(
Expand Down

0 comments on commit a8b37f1

Please sign in to comment.