-
Notifications
You must be signed in to change notification settings - Fork 847
i18n(tr): improve Turkish translations and parity with EN #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
i18n(tr): improve Turkish translations and parity with EN #898
Conversation
- Fix terminology: Polish→Parlat, Precise→Kesin, Float window→Pencereyi Yüzdür, UNAUTHORIZED→Yetkisiz - Normalize URL wording (API URL’si), Enter/Shift hints - Improve clarity: context length message, security check wording - Add missing keys from EN (retry button hint, crop text setting) - Minor punctuation/consistency fixes Build & lint: PASS
Summary of ChangesHello @cenktekin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Turkish localization of the application by refining existing translations for improved clarity, consistency, and natural language use. It also incorporates translations for previously missing English keys, ensuring a more complete and user-friendly experience for Turkish speakers. All changes are confined to the localization file, with no impact on runtime logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated Turkish translations across UI strings: capitalization/casing fixes, API/URL terminology, help/error guidance, window behavior labels, token-related messages, and the addition of a "Crop Text" translation entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)src/_locales/**/main.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the Turkish localization by refining terminology, enhancing clarity, standardizing wording, and adding missing translations. The changes demonstrate a good understanding of both the source text and Turkish language nuances. I have a couple of minor suggestions to further improve consistency and completeness, but overall, this is excellent work that will greatly benefit Turkish-speaking users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/_locales/tr/main.json(9 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/_locales/**/main.json
📄 CodeRabbit inference engine (AGENTS.md)
Do not change localization keys; add keys only in
en/main.jsonand propagate values to other locales
Files:
src/_locales/tr/main.json
🔇 Additional comments (1)
src/_locales/tr/main.json (1)
15-163: Translation improvements look good overall.The terminology updates (Url → URL'si, UNAUTHORIZED → Yetkisiz, Polish → Parlat, Precise → Kesin, Float the Window → Pencereyi Yüzdür) improve clarity and parity with the English version. Message expansions (lines 50, 94, 106) add helpful user guidance. Capitalization and punctuation consistency throughout the file is solid.
…n- Remove non-EN key from TR locale\n- Set value of existing key to retry-button hint (matches EN mapping)
…e 'to avoid blocking' meaning
|
Applied minor suggestions: capitalized Enter/Shift in the stop-generating hint and restored ‘to avoid blocking’ for parity. Formatted, linted, build OK. Commit: dca858a |
User description
Summary
Scope
Validation
Manual sanity checks
Notes
PR Type
Documentation
Description
Improve Turkish terminology consistency and clarity
Normalize URL and technical wording across translations
Expand error messages with actionable guidance
Add missing English keys to Turkish localization
Minor punctuation and wording refinements for consistency
Diagram Walkthrough
File Walkthrough
main.json
Turkish localization improvements and English paritysrc/_locales/tr/main.json
the Window" → "Pencereyi Yüzdür", "UNAUTHORIZED" → "Yetkisiz"
"Jeton"
consistency
button hint
not exceed the model's limit"
dek" → "Süresiz"
Summary by CodeRabbit