WIP: Replace nonresolving domain names in URLs in test cases to speed up tests #13813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Inject .example. where pertinent to avoid long DNS timeouts
|
No discernible difference in Github Actions timings; CircleCI seems slower than otherwise, if anything. )-: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject .example. where pertinent to avoid long DNS timeouts
This shaves off several minutes from tests on my laptop, but I don't know how well it transfers.
There are also a couple of tests which still exhibit DNS timeouts even after I moved them to example.com.
FWIW none of the domains here had blacklist entries which changed in any way because of these changes (either they were not blacklisted in the first place, or the change did not affect which blacklist entries would trigger).