Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ops): fix Github action to publish on NPM #45

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat(ops): fix Github action to publish on NPM #45

merged 2 commits into from
Jul 22, 2024

Conversation

Dam-Buty
Copy link
Contributor

@Dam-Buty Dam-Buty commented Jul 18, 2024 •
edited
Loading

  • Adds a convenience script for releases (npm run release)
  • The secret is fixed, however the PAT has a time limit of 90 days
    • I've documented on Notion how to replace it
  • As a treat, i added timeouts & sleeps in the tests so they are somewhat less flaky 🥣

@linear Linear
Copy link

linear bot commented Jul 18, 2024

ENG-1637 Automate TS SDK release on github action

The logic is already kinda coded but the issue was npm 2FA

@Dam-Buty Dam-Buty force-pushed the damien/eng-1637-automate-ts-sdk-release-on-github-action branch from 09cacf6 to 17bc276 Compare July 18, 2024 08:09
@Dam-Buty Dam-Buty force-pushed the damien/eng-1637-automate-ts-sdk-release-on-github-action branch from 6662978 to e62d773 Compare July 18, 2024 08:57
@desaxce desaxce self-requested a review July 22, 2024 07:24
desaxce
desaxce approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@desaxce desaxce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, we test it today?

release.sh
NC='\033[0m'

echo "🪜 Incrementing version number"
npm version patch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your case of releasing a TS SDK that's a major/minor, we temporarily add the right level we want to release, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There hasn't been any traction to the idea of bumping to minor so for the moment we'll only be releasing patches i think

@Dam-Buty Dam-Buty merged commit 28fc8c4 into main Jul 22, 2024
2 checks passed
@desaxce desaxce deleted the damien/eng-1637-automate-ts-sdk-release-on-github-action branch July 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desaxce desaxce desaxce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dam-Buty @desaxce