Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): relax peer dependency version rules #33

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Dam-Buty
Copy link
Contributor

@Dam-Buty Dam-Buty commented Jun 19, 2024

As discussed on Slack, I wonder if it is legitimate to caret-pin exact versions of the peer dependencies.

This leads to an uncomfortable situation if a peer package has released a new version since the last cut of the TS SDK. For example the latest version of the Vercel AI SDK is 0.0.24 , but the TS SDK had it pinned at 0.0.9. This is solved in v0.0.507 of the SDK but in the meantime it produced NPM errors which are hard to solve : either the user had to downgrade the AI SDK they used, or to npm install --force to ignore the error.

IMO it is much more flexible to allow peer dependencies at a known version or above. WDYT ?

(btw since i noticed this, AI SDK is now at 0.0.31 so we are back to being incompatible :'( )

@willydouhard willydouhard merged commit 327a887 into main Jun 19, 2024
2 checks passed
@willydouhard willydouhard deleted the dby/fix-caret-peer-deps branch June 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants