fix(deps): restore compatibility with Next.js build #31
+3
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dam-Buty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Next.js build system was too aggressive in its tree shaking and removed
mime-typesfrom the bundle (required byform-datawhich is required by@literalai/client).It was the dumbest thing as
mime-typeswas declared as a dep despite not being imported anywhere in the code, whileform-datawas imported in the code but not declared as a dep. This didn't trigger any compile error as it is mainlined in Node (and presumed to exist by tsc/swc) but the build process messed the whole dependency graph and the error appeared at runtime.