fix: Sort thread history groups in fixed order #1967
Merged
+71
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
willydouhard
requested changes
Mar 7, 2025
| <SidebarMenuButton | ||
| isActive={isSelected} | ||
| className="relative truncate h-9 group/thread" | ||
| {Object.keys(threadHistory.timeGroupedThreads ?? {}) |
There was a problem hiding this comment.
we could use useMemo here
|
It’s difficult to reproduce intentionally, but I’ve seen instances—and others have too—where the keys ended up in a different order than expected. This isn’t something we can easily trigger on demand, but those sporadic cases were enough to warrant adding explicit sorting for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the inconsistent order of thread history groups in the left sidebar. The groups (Today, Yesterday, Previous 7 days, Previous 30 days) were stored as object keys, and JavaScript does not guarantee their order. I added explicit sorting using a fixed order array so that the groups always appear in the intended order.