Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-client): Chat settings won't be resumed when resuming thread #1929

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

tcx4c70
Copy link
Contributor

@tcx4c70 tcx4c70 commented Feb 26, 2025

When resuming thread, the backend has already sent the chat setting values to the frontend. However,
the frontend doesn't resume the values. As a result, the setting button will be disappeared after resuming
the thread.

This PR will resume the setting values in the frontend when resuming the thread to fix the problem.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. frontend Pertains to the frontend. labels Feb 26, 2025
@tcx4c70 tcx4c70 force-pushed the fix/resume-chat-settings branch 2 times, most recently from 6b35431 to 6025a00 Compare March 7, 2025 05:32
@tcx4c70 tcx4c70 force-pushed the fix/resume-chat-settings branch from 6025a00 to 94d32dd Compare March 8, 2025 12:16
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willydouhard willydouhard added this pull request to the merge queue Mar 9, 2025
Merged via the queue into Chainlit:main with commit 863a5b9 Mar 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pertains to the frontend. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants