-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markdown alert syntax support with unsafe_allow_html = true #1908
Merged
willydouhard
merged 8 commits into
Chainlit:main
from
hexart:fix/markdown-alert-unsafe-html
Mar 7, 2025
Merged
fix: markdown alert syntax support with unsafe_allow_html = true #1908
willydouhard
merged 8 commits into
Chainlit:main
from
hexart:fix/markdown-alert-unsafe-html
Mar 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix alert syntax (:::) parsing when unsafe_allow_html=true - Add support for HTML alert tag with type attribute: <alert type="info">content</alert>
- Move normalizeAlertType to MarkdownAlert - Remove duplicate code in Markdown component
3 tasks
willydouhard
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When
unsafe_allow_html = true
, markdown-alert component has two issues:Solution
unsafe_allow_html = true
Verified
With
unsafe_allow_html = true
:With
unsafe_allow_html = false
:Usage
Addition
Add type validation in both markdown mode and html tag mode.
If type error, alert will fall back to
info
type.Testing code
Details