-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace asyncio default event loop with uvloop #1790
base: main
Are you sure you want to change the base?
Conversation
Unfortunately I don't think this is possible, we need re-entrancy for stuff like AskUser |
But then the tests are passing. @asvishnyakov Does this mean we can do away with the asyncio dependency? As I'm not (yet) convinced there's a strong use case for this and @willydouhard suggests it's not possible, I propose we leave this open for a bit until either:
The rationale being: if it's not (demonstrably) broken... |
@dokterbob I’m new to Python, so I’m not entirely sure myself 😄. I’m trying to investigate performance issues in my app, and while this is definitely not a bottleneck, I was surprised to see it working better after the change. I think we need proper performance tests. Also, it looks like, as a workaround, I can run chainlint as a sub-app and configure uvloop for the main app, if needed. |
This is my proposed solution to #1789. Feel free to edit or close if I'm wrong