Add missing oracles to Somnia - #2058
Conversation
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The current-cycle link-check passed and the CSV structure is valid, but the PR adds many Somnia oracle listings without Somnia-specific evidence for the provider/network relationship.
Findings:
- HIGH, listings/specific-networks/somnia/oracles.csv:2-3,6-7,10-28,30-46: the newly added oracle rows all leave
actionButtonsempty while asserting both Somnia mainnet and testnet support. The canonical!offer:rows describe the oracle products generally; they do not prove that each oracle is available on Somnia. Please add Somnia-specific provider/docs/source links for each supported row and remove any provider/chain rows that cannot be verified.
Confidence: HIGH
|
@elevasyncsolutions-jpg thanks for the PR. This has been idle for more than 3 days and still has unresolved requested changes. Please address the review feedback and update the PR when it is ready. |
|
Hi @elevasyncsolutions-jpg - this PR is stale and still has unresolved requested changes. Could you please address the review feedback and update the PR when ready? |
|
Thanks for the review. Fixed: kept only the four oracle providers with verified Somnia-specific source links:
|
|
Hi @elevasyncsolutions-jpg - this PR is stale, and review should wait until required CI is passing. The current blocker is: no required checks reported. Could you please fix or trigger CI and update the PR when ready? |
…innet (protofire price feeds per Somnia docs)
4280300 to
79babe8
Compare
|
Closing as no-op: every oracle row this PR added (Stork, Scry, Pyth, Tellor, eOracle) has since been merged into main directly — main"'s repositories/specific-networks/somnia oracles now carry the full set with provider and docs, including rows contributed via PR #1993. Rebuilding this branch against latest main produces zero net changes (0 files). No further work needed. |
Add missing oracles to Somnia.
All entries reference existing canonical offers from references/offers/oracles.csv.
Reward address: 0x0920555F38a7dfB2b8417262be2b82f7bCbf019c