You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @es3298 - this PR is stale, and review should wait until required CI is passing. Current status: no checks reported on the 'es3298/arbitrum-sdk-metadata' branch. Could you please fix or trigger CI and update the PR?
Hi @es3298 - closing this stale PR for now because required CI is still not passing. The next step after my previous Supervisor ping was on the PR creator side, and the PR stayed unattended for more than 7 full days after that ping with no meaningful update. Please feel free to reopen or recreate it once the blocker is addressed and the PR is ready again.
A couple of repository conventions should be followed here:
Please keep canonical offer data in references/offers/... and use network listings only for network-specific overrides (such as chain, network-specific URLs, contract addresses, or other values that actually differ for that network). Avoid duplicating canonical metadata directly in listings/....
Please also pay close attention to which fields are intended to be maintained manually. Metadata fields such as latestKnownVersion, latestKnownReleaseDate, maintainer, and license are maintained automatically and should not be edited manually in PRs.
The reason will be displayed to describe this comment to others. Learn more.
Verdict: APPROVE
Risk: LOW
Summary: The current diff only updates the existing Arbitrum SDK canonical offer row in references/offers/sdks.csv: action buttons now point to the official GitHub repo and npm package, the description hyphen is normalized, and price whitespace is trimmed. CSV structure is unchanged, no slugs or rows were added/removed, and the parsed actionButtons cell is valid Markdown-link JSON. Required validation is SUCCESS, and current-head link-check run 30090020710 reports 2/2 successful links with 0 errors/timeouts.
Findings: None.
Confidence: HIGH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cross-chainSources
Validation
Import-Csv listings\specific-networks\arbitrum\sdks.csvparses 18 headers and 81 rowsactionButtonsforarbitrum-sdkas JSONgit diff --checkReward address: if this qualifies for the bounty after review, please tag @es3298 and I will provide the ERC20 Ethereum Mainnet USDC/USDT address.