Add Stork, Scry Protocol, SEDA to the oracles.csv file#1993
Conversation
|
Hi @Adisaok - this PR is stale, and review should wait until required CI is passing. Current status: no checks reported on the 'patch-834717' branch. Could you please fix or trigger CI and update the PR? |
Hi @eugene17kotov, please, what is left for me to fix on this PR? |
|
Hi @Adisaok - this PR is stale, and review should wait until required CI is passing. Current status: no checks are currently reported on the |
|
Hi @Adisaok - this PR is stale, and review should wait until required CI passes. Current status: no checks reported. Could you please fix or trigger CI and update the PR when ready? |
…update SEDA and add for other logos.
…SEDA, and Stork, including changes to their descriptions and features.
… networks to reflect changes in Stork, Scry Protocol, and SEDA classifications and network specifications.
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: CI and the latest link-check are green, and the CSV structure/references parse cleanly, but the PR adds or touches network-specific SEDA oracle listings that I could not verify against SEDA's official supported EVM/prover deployment source. Please either remove those rows or add official SEDA evidence for those exact target networks.
Findings:
- [MEDIUM] listings/specific-networks/ethereum/oracles.csv:16, listings/specific-networks/filecoin/oracles.csv:5, listings/specific-networks/polygon/oracles.csv:7, listings/specific-networks/somnia/oracles.csv:10 - These rows list
!offer:sedafor Ethereum mainnet, Filecoin mainnet, Polygon mainnet, and Somnia mainnet. SEDA's official Prover Contract Deployments table lists ArbitrumOne and several other networks, but not these target networks, and the SEDA agent guidance says to stop if the target chain is not listed. For network-specific listings, please remove unsupported rows or provide an official SEDA source showing SEDA support for each exact network/chain value. Source: https://docs.seda.xyz/home/technology/seda-network-architecture/seda-core/seda-core-infrastructure-overview/prover-contract-deployments.md and https://docs.seda.xyz/home/for-agents/agent-modules/prover-contract-deployments.md - [LOW] references/offers/oracles.csv:21 - The new
scry-protocoloffer row leaves a single-space value in the finaltagcolumn (...,,,). Please make that field truly empty.
Confidence: HIGH
…lygon, and Somnia networks to streamline oracle listings.
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The follow-up commit removes the unsupported SEDA rows from Ethereum, Filecoin, Polygon, and Somnia, and fixes the blank tag field in references/offers/oracles.csv. CSV shape, duplicate checks, offer references, provider logo paths, and the remaining network rows all check out; SEDA remains only on ArbitrumOne, Stork has exact contract-address coverage for the changed networks, and Scry is documented as EVM-focused/permissionless oracle infrastructure. Required validation passes on a976391, and fresh link-check run 30086879486 reports 33/33 successful links with 0 errors/timeouts.
Findings: None.
Confidence: HIGH
Summary
Type of change
Scope
Networks affected:
Categories affected:
Additional notes, additional context / screenshots:
Links
Validation checklist
!providersyntax, and that entities in/networkssub-folders inherits records from/providersfolderOptional