Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vocabulary URLs to LIDIA terms #25

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Add vocabulary URLs to LIDIA terms #25

merged 9 commits into from
Mar 28, 2024

Conversation

ar-jan
Copy link
Collaborator

@ar-jan ar-jan commented Mar 27, 2024

Depends on the changes to the spreadsheet in CentreForDigitalHumanities/lidia-zotero#76.

@ar-jan ar-jan requested a review from tijmenbaarda March 27, 2024 12:32
@ar-jan ar-jan changed the title Add external URLs to LIDIA terms Add vocabulary URLs to LIDIA terms Mar 27, 2024
tijmenbaarda
tijmenbaarda reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tijmenbaarda tijmenbaarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! There are some hardcoded filepaths left in the code though, see comments.

@ar-jan ar-jan merged commit 05ecdaa into develop Mar 28, 2024
2 checks passed
@ar-jan ar-jan mentioned this pull request Mar 28, 2024
Closed
@ar-jan ar-jan deleted the feature/term-urls branch January 9, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijmenbaarda tijmenbaarda tijmenbaarda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ar-jan @tijmenbaarda