Skip to content

fix: validate endpoint and SSL configuration - #9

Merged
CasualEngineerZombie merged 13 commits into
mainfrom
fix/ssl-endpoint-configuration
Sep 21, 2026
Merged

CasualEngineerZombie merged 13 commits into
mainfrom
fix/ssl-endpoint-configuration

Conversation

@CasualEngineerZombie

@CasualEngineerZombie CasualEngineerZombie commented Sep 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Define a single, predictable relationship between RUSTFS_ENDPOINT and RUSTFS_USE_SSL.
  • Reject contradictory HTTP/HTTPS and SSL configurations.
  • Resolve scheme-less endpoints from RUSTFS_USE_SSL.
  • Ensure boto3 receives the resolved endpoint, SSL mode, certificate verification, and timeout settings.
  • Add tests and documentation for endpoint/TLS behavior.

Changes

  • Added resolve_endpoint() to validate and normalize endpoint configuration.
  • HTTP endpoints require RUSTFS_USE_SSL=False.
  • HTTPS endpoints require RUSTFS_USE_SSL=True.
  • Scheme-less endpoints derive their scheme from RUSTFS_USE_SSL.
  • Unsupported endpoint schemes are rejected.
  • Updated storage to use the canonical configuration layer.
  • Pass RUSTFS_USE_SSL and RUSTFS_VERIFY_SSL directly into boto3.
  • Pass canonical RUSTFS_CONNECT_TIMEOUT and RUSTFS_READ_TIMEOUT values into botocore.
  • Added tests covering HTTP/HTTPS endpoint resolution and boto3 client configuration.
  • Documented the supported endpoint/SSL combinations.

Closes #8

Validation

CI should validate Ruff, mypy, and pytest across the supported Python/Django matrix. The PR has not been merged.

@CasualEngineerZombie
CasualEngineerZombie merged commit 856f300 into main Sep 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix SSL and endpoint configuration

1 participant