Skip to content

Feature/java client apache connector#2302

Merged
danoswaltCL merged 3 commits intodevfrom
feature/java-client-apache-connector
Apr 1, 2025
Merged

Feature/java client apache connector#2302
danoswaltCL merged 3 commits intodevfrom
feature/java-client-apache-connector

Conversation

@danoswaltCL
Copy link
Copy Markdown
Collaborator

Smoke test of this worked for me testing with the QuickTest.java file (formerly Main.java). I installed JDK 17 on my local, and then when I target 17 here in properties for the jersey client instead of 8 I was able to replicate the PATCH error. After installing the updated dependency for apache connector as it was in the PR from years back, the error went away.

<properties>
		<jersey.version>2.30.1</jersey.version>
		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
		<maven.compiler.source>17</maven.compiler.source>
		<maven.compiler.target>17</maven.compiler.target>
	</properties>

Let me know what else we should consider to test, and if there are other deps we should go ahead and update alongside of this let's go ahead.

@danoswaltCL danoswaltCL requested a review from jerith666 March 20, 2025 21:46
Copy link
Copy Markdown
Contributor

@jerith666 jerith666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dug around some more and can't find any evidence of why we didn't go with this approach back in 2023. I guess we'll just have to rediscover it if there was some real problem. :-/

Anyway, the substance looks good here, just a couple of minor tweaks.

Comment thread clientlibs/java/pom.xml Outdated
Comment on lines +25 to +26
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They unified source and target into a new release parameter:

Suggested change
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>

Comment thread clientlibs/java/pom.xml Outdated
by a merge conflict. -->

<version>6.1.0</version>
<version>6.1.1</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this library has seen very few updates recently, I still think the comment just above is reasonable. So:

Suggested change
<version>6.1.1</version>
<version>6.1.1</version> <!-- 6.1.1: switch to jersey-apache-connector -->

@jerith666
Copy link
Copy Markdown
Contributor

Also there seem to be several failing NPM tests, probably we'll need another PR to land to clean those up before this one lands?

@danoswaltCL
Copy link
Copy Markdown
Collaborator Author

That build failure is to be ignored, I don't know why it can't be suppressed/ignored on dev, I've asked. But long story short is that task fails on dev because it is only for beanstalk builds, we have no dev beanstalk env anymore, and we haven't felt like fixing errors for a pointless task, but it lingers around because it still needs to exist for staging and prod. At the time it seemed like the switchover to ECS was going to happen more imminently, but it hasn't, so we've just sort of ignored it.

the equivalent build task for ECS (upgrade-service) passes.

I am going to assume this was some dangling task that Jenn had been working on when she left and got lost in the void.

@danoswaltCL danoswaltCL requested a review from jerith666 April 1, 2025 14:43
Copy link
Copy Markdown
Contributor

@jerith666 jerith666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense; the ECS switchover is actually happening now, so hopefully we can in fact get rid of that check soon.

@danoswaltCL danoswaltCL merged commit de6aefc into dev Apr 1, 2025
14 of 15 checks passed
@danoswaltCL danoswaltCL deleted the feature/java-client-apache-connector branch April 1, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants