Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Created and Updated dates for fresh and imported experiments-ff-segments #2299

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

ppratikcr7
Copy link
Collaborator

@ppratikcr7 ppratikcr7 commented Mar 19, 2025

This PR resolves #2213

It will resolve the below things:

  1. The created date for the imported experiment/feature-flag/segment will have the current created date instead of old date as per the design JSON.
  2. The updated date for the imported and freshly created experiment/feature-flag/segment will have a blank (-) date as they are freshly created and not updated yet. Below are attached screenshot for the same.
  3. Once we update the experiment/feature-flag/segment, we will store the updated date and update the versionNumber for these tables and based on the versionNumber, we will show the updated on date.
  4. Added date-time for experiments and segments details page as in feature-flags pages' updated-date field for uniformity and it helps differentiate the created and updated times, else we just show dates which can be same for the same date. (Let me know in case this is not intended)
  5. Replaced the async import from frontend tests as its deprecated from @angular/core/testing after angular update. We need to use waitForAsync instead. Please find attached screenshot.
  6. Updated a spelling error for the isMoocletAssignmentAlgorithm in ExperimentDTO.
Screenshot 2025-03-19 at 2 47 20 PM

Blank updated dates for freshly created or imported segments:

Screenshot 2025-03-19 at 5 24 50 PM

Complete date-time for created at as well, earlier we had date-time for only updated-at in Feature-Flag:

Screenshot 2025-03-18 at 7 10 33 PM

@ppratikcr7
Copy link
Collaborator Author

Note: Here as observed we dot update the feature-flag and segment tables on updating the inclusion/exclusion lists and segment-members. Also, toggle update for feature-flag wont update the feature-flag table, so the versionNumber wont be incremented. Should we update these tables on the above mentioned scenarios, though it might seem an over-kill for the ticket created.

@ppratikcr7 ppratikcr7 marked this pull request as ready for review March 19, 2025 13:58
danoswaltCL
danoswaltCL previously approved these changes Mar 19, 2025
Copy link
Collaborator

@danoswaltCL danoswaltCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@ppratikcr7 ppratikcr7 merged commit 6904c6c into dev Mar 24, 2025
7 of 8 checks passed
@ppratikcr7 ppratikcr7 deleted the bugfix/import-created-at branch March 24, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants