✨ Adding validations

[VivekFitkariwala]

Adding validation of policy parameters

[VivekFitkariwala]

@bcb37, validations are working. Can you check it once?

[danoswaltCL]

Without the default values for prior and it's properties, the frontend can't create a default object, the priors as "prior": { "success": 1, "failure": 1 } should show up here in the editor.

[danoswaltCL]

The validation isn't quite working for me on the frontend when I fill in prior manually either, it allows me to hit "next" with an object like below. It does catch it on submit and give correct message, however the other validations will raise an error immediately as the user types.

{
"prior": {
"success": "d",
"failure": 2
},

[VivekFitkariwala]

We should not add the default values in the class constructor because class transform uses this class constructor to create the definition and assign the object (to be tested) to the constructed object. If we are adding the default values, the constructor definition also contains the value which we don't want.
For testing, add the default value for Prior in the types
Remove the "prior": { "success": 1, "failure": 1}.
It will not throw an error.

I can add the appropriate config for the frontend side for validation to work correctly.

[bcb37]

@bcb37, validations are working. Can you check it once?

In addition to Dan's comment about the default values (which works if we're defining the types within the root), we also need to disallow extraneous attributes. That works if you add { whitelist: true, forbidNonWhitelisted: true, forbidUnknownValues: true } as the value for 'validate' in the controller.
But we do want to be able to use those default values.

You'll notice that default values are used based on DTO for non-nested attributes (e.g. "batch_size"). I'm still fairly sure the nested types are not being added to the right reflect-metadata instance, though using 'enableImplicitConversion' gets us part of the way there.

[VivekFitkariwala]

@bcb37 I don't think that we have two different instances of reflect-metadata because I am able to re-create the issue even after pasting the code in the backend. It seems like it is related to the discriminator.

[danoswaltCL]

To be continued, validation still need attention but closing as we need the default behavior.