Refactor NostraAlpha loan states, fix interest rate indices in NostraDataParser #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeck1432
reviewed
Feb 26, 2025
| @@ -110,47 +110,6 @@ def process_data(self, data: list[dict]) -> pd.DataFrame: | |||
| result_df = self.get_result_df(nostra_mainnet_state.loan_entities) | |||
| return result_df | |||
|
|
|||
| def get_result_df(self, loan_entities: dict) -> pd.DataFrame: | |||
There was a problem hiding this comment.
So you are using default get_result_df ?
There was a problem hiding this comment.
Yes, I added this method myself for Nostra Mainnet as part of issue 439. However, since both Nostra Mainnet and Nostra Alpha are now handled the same way, this method is no longer needed here
There was a problem hiding this comment.
okay, I see now, thank you
…DataParser and clean up loan state computation methods
MrRoudyk
force-pushed
the
feat/469-nostra-alpha-validation
branch
from
f7fcd52 to
fc80978
Compare
|
@MrRoudyk Please fix failed test cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469
Event Processing and Parsing Updates:
apps/data_handler/handler_tools/data_parser/nostra.py: Updated the indices forlending_indexandborrow_indexin theparse_interest_rate_model_eventfunction to correctly reflect the event data structure. [1] [2]Adding New Event Types:
apps/data_handler/handler_tools/nostra_alpha_settings.py: Added new event types forinterest_bearing_collateralandnon_interest_bearing_collateralfor both mint and burn events. [1] [2]Refactoring and Code Cleanup:
apps/data_handler/handlers/loan_states/abstractions.py: Refactored theget_result_dfmethod to simplify the processing of loan entities and handle collateral data more robustly.apps/data_handler/handlers/loan_states/nostra_alpha/events.py: Various refactoring changes including switching toget_async_symbolfor asynchronous symbol fetching, and adding helper methods_is_ignored_userand_get_safe_interest_rateto improve code readability and maintainability. [1] [2] [3] [4]