Use half minutes and a signed offset for timestamp #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the absolute time being a full minute and offsets being unsigned, it is much harder to send an older measurement in a newer packet. With half-minutes and a signed offset, the log time is cut in half but a measurement's offset is always compatible with the previous and next half-minute to have occured
linguini1
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the absolute time being a full minute and offsets being unsigned, it is much harder to send an older measurement in a newer packet. With half-minutes and a signed offset, the log time is cut in half but a measurement's offset is always compatible with the previous and next half-minute to have occurred