Update remaining TODOs

[JanKuczma]

Summary by CodeRabbit

• Documentation

  • Updated security documentation by removing outdated PoC-specific limitation notes.

• Chores

  • Removed internal documentation files.
  • Simplified build instructions in README.

• Bug Fixes

  • Fixed account validation timing in migration wallet logic.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2ba3c350-4ac7-4dc9-b33e-66c636a3b387

📥 Commits

Reviewing files that changed from the base of the PR and between d2abc67 and 1b009f3.

📒 Files selected for processing (1)

• noir/aztec-state-migration/src/mode_a/migration_data_event.nr

---

Walkthrough

This PR reduces public visibility of internal structures and methods across the Noir state migration library, removes proof-of-concept documentation files, updates documentation, reorders module declarations, and fixes a null-check ordering issue in TypeScript code.

Changes

Cohort / File(s)	Summary
Documentation Cleanup TODO_MODE_A.md, TODO_MODE_B.md, docs/security.md, README.md	Removed Mode A and Mode B PoC documentation files, deleted PoC limitation bullets from security documentation, and removed TypeScript build compilation reference from README.
Noir Visibility Restrictions (Mode A) noir/aztec-state-migration/src/mode_a/migration_data_event.nr, noir/aztec-state-migration/src/mode_a/migration_note.nr	Restricted visibility of MigrationDataEvent<T> struct and its fields from public to pub(crate), and reduced MigrationNote struct fields from public to private.
Noir Module Reordering noir/aztec-state-migration/src/mode_a/mod.nr	Reordered module declarations to move mod migration_lock and its re-export after the builder module declarations.
Noir Visibility Restrictions (Mode B) noir/aztec-state-migration/src/mode_b/key_note_proof_data.nr, noir/aztec-state-migration/src/mode_b/non_nullification_proof_data.nr, noir/aztec-state-migration/src/mode_b/public_state_proof_data.nr	Restricted visibility of methods and struct fields from public to pub(crate) across proof data structures.
Noir Core Visibility Restrictions noir/aztec-state-migration/src/note_proof_data.nr	Reduced visibility of struct fields (randomness, nonce, leaf_index, sibling_path) and methods (verify_note_inclusion, note_hash) to pub(crate) or private.
TypeScript Updates ts/aztec-state-migration/wallet/migration-embedded-wallet.ts, ts/aztec-state-migration/mode-b/signature.ts	Moved account null-check earlier in the execution flow before constructor usage, and simplified imports to use only Fr and DOM_SEP__CLAIM_B.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

• Fix: Migration Data Id in MigrationDataEvent #48: Modifies the same MigrationDataEvent<T> struct in noir/aztec-state-migration/src/mode_a/migration_data_event.nr (adds a data_id field while this PR tightens visibility).
• Restructure TypeScript SDK as publishable npm package #43: Updates the same ts/aztec-state-migration/wallet/migration-embedded-wallet.ts file touched in this PR.

Suggested reviewers

• DamianStraszak

Poem

🐰 The public doors now close with care,
Internal secrets tucked away fair,
Mode A and B docs take their flight,
While visibility dims to crate-private light,
A tidy refactor, precise and right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Update remaining TODOs' is vague and generic, using non-descriptive terminology that does not clearly convey the specific changes made in the changeset.	Consider a more specific title that describes the primary changes, such as 'Restrict internal API visibility in Noir and TypeScript migration modules' or 'Clean up PoC documentation and reduce public API surface'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jk-misc

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@TODO.md`:
- Line 11: The release docs line under "Publish TS SDK package" currently uses
incorrect capitalization for GitHub; update the text that references the publish
workflow and the publish step (the "Publish TS SDK package" entry) so the
platform name is capitalized as "GitHub" everywhere in that line and any related
release documentation strings.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77181a0 and 4f8f147.

📒 Files selected for processing (5)

• TODO.md
• TODO_MODE_A.md
• TODO_MODE_B.md
• docs/security.md
• ts/aztec-state-migration/wallet/migration-embedded-wallet.ts

💤 Files with no reviewable changes (3)

• TODO_MODE_A.md
• TODO_MODE_B.md
• docs/security.md