AZ-219 Replaced statefull force push check when pull requests are merged

[Marcin-Radecki]

This PR replaces a stateful force push check when pull requests are merged with a stateless version bump check when a new commit is pushed to any PR with the target branch as main.

The motivation of this change is to remove the solution with git push --force, and yet still have most of its features:

• developer synchronization: with git push --force it is for CI to decide to bump the last version on main to the next one, so developers do not need to track if the version on main changed meanwhile sb merged other PR. With the proposed solution we don't have this particular gain, however, it should be rare people won't figure out the version changed meanwhile,
• automatic solution prevented people from forgetting to update the version - this still holds, you can't merge PR which has source code changes without version bumped in it,
• commit atomicity, ie we want ideally to have the version bumped in the same commit as the change due to the current way of publishing AlephBFT to crates.io - this still holds,
• additional gain to remove git push --force is we can enable main as protected branch in GitHub, and that prevents git push --force from outside as well as forces PR to be raised with given a configurable minimal amount of approvers (this works on our other aleph-node repo).

Once this PR is merged, the other one #165 would be declined (thanks for that work which influenced this PR).

Testing done:

• .github/workflows/check-version-bumped.yml was tested on the fork, see test1: added new line Marcin-Radecki/AlephBFT#3 and history of commits on that PR
• .github/workflows/push-foundation-repo.yml change was not tested due to its nature,
• .github/workflows/push-foundation-repo.ymlwas partially tested, with modified version (Marcin-Radecki@ff9475b, Marcin-Radecki@13a890d): on PR merged Feature/testing crates io push Marcin-Radecki/AlephBFT#4 this action was run https://github.com/Marcin-Radecki/AlephBFT/runs/4787358743?check_suite_focus=true

[github-actions]

Please make sure the following happened

• [N/A] Appropriate tests created
• [N/A ] Infrastructure updated accordingly
• Updated existing documentation (https://www.notion.so/cardinalcryptography/Dev-Workflow-Rules-5b6732e1e3d04850a15be1a6e6126a9a)
• [N/A] New documentation created
• [N/A] Version bumped if breaking changes

[bartoszjedrzejewski]

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

[Marcin-Radecki]

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

[timorl]

Nice, much better than forcepushing.

[bartoszjedrzejewski]

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

ok, but why waste github actions seconds pool for nothing. You can use this: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-ignoring-paths
It's not a nogo for me, but would be nice to have it implemented.

[Marcin-Radecki]

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

ok, but why waste github actions seconds pool for nothing. You can use this: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-ignoring-paths It's not a nogo for me, but would be nice to have it implemented.

Let me try with those paths, agreed if we can make it work so workflow are not spawned for nothing then it's better.

[kostekIV]

lgtm :)

[Marcin-Radecki]

I've applied review remarks and it's better now, apart from cleaner bash we don't waste Guthub resources, and it's cleaner to developers than checks are run only if they modify particular files.

Testing done:

• Testing remarks from PR, version #2 Marcin-Radecki/AlephBFT#5
• Feature testing remarks Marcin-Radecki/AlephBFT#6

[Marcin-Radecki]

In particular, you can see that two new checks are in place and triggered, since this PR modifies both src/ path and Cargo.toml:

[timorl]

<3

[Marcin-Radecki]

Everything worked as expected after merge:

• Code was synced to AlephFoundation: https://github.com/Cardinal-Cryptography/AlephBFT/runs/4801326323?check_suite_focus=true
• Create was uploaded to crates.io: https://github.com/Cardinal-Cryptography/AlephBFT/runs/4801326331?check_suite_focus=true