카카오 로그인 통합 #11
Closed
카카오 로그인 통합 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. PR 분석 보고서Walkthrough배포 설정을 업데이트하고 gRPC 프로토 메시지를 재구조화하며, 카드/혜택/프로모션 엔티티를 리팩토링했습니다. 인증 흐름을 단순화하고, 하드코딩된 사용자 ID를 Changes
Sequence Diagram(s)sequenceDiagram
participant Crawler as Crawler Server
participant gRPC as gRPC Service
participant Event as Event Listener
participant Service as Change Detection
participant Repo as Repository
Crawler->>gRPC: saveCardData(CardBenefitList)
gRPC->>Event: publishEvent(CardDataReceivedEvent)
Event->>Service: processCardBenefitList(CardBenefitList)
Service->>Repo: findByCardId(cardId)
alt Card exists
Service->>Repo: update Card & Benefits
else Card not found
Service->>Repo: create new Card & Benefits
end
Service->>gRPC: CardSaveResponse(success)
gRPC->>Crawler: response
sequenceDiagram
participant Client as Client
participant Ctrl as PromotionController
participant Service as PromotionService
participant Auth as AuthUtils
participant Repo as Repositories
Client->>Ctrl: GET /api/promotions/active
Ctrl->>Service: getActivePromotions()
Service->>Auth: getMemberId()
Auth-->>Service: userId
Service->>Repo: getUserCards(userId)
Repo-->>Service: List<Card>
Service->>Repo: findActivePromotions(cardCompanies, now)
Repo-->>Service: List<CardPromotion>
Service-->>Ctrl: List<ActivePromotionResponse>
Ctrl-->>Client: 200 OK + promotions
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 특별히 주의가 필요한 영역:
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (63)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ 작업 내용
📸 스크린샷(선택)
📚 리뷰 요구사항(선택)
(프론트의 요청사항) login에 회원가입 및 로그인 통합함.
Summary by CodeRabbit
릴리스 노트
New Features
Refactor
Chores