Skip to content

docs: clarify isRooted result field in README - #3

Merged
riderx merged 2 commits into
Cap-go:mainfrom
TorichanCapgo:docs/isrooted-result-field
Feb 21, 2026
Merged

docs: clarify isRooted result field in README#3
riderx merged 2 commits into
Cap-go:mainfrom
TorichanCapgo:docs/isrooted-result-field

Conversation

@TorichanCapgo

@TorichanCapgo TorichanCapgo commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an explicit isRooted() usage example in README
  • clarify that DetectionResult uses the result boolean field

Fixes confusion reported in #2.

Summary by CodeRabbit

  • Documentation
    • Added a code example demonstrating async usage of isRooted(), showing how to call it and check the boolean result.
    • Clarified that DetectionResult exposes a boolean result field and made minor formatting improvements to the documentation.

@coderabbitai

coderabbitai Bot commented Feb 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Documentation update to README.md adding an example for isRooted() usage and a clarification that DetectionResult's result field is a boolean. No API, public declarations, or functional code were changed.

Changes

Cohort / File(s) Summary
Documentation
README.md
Added an async usage example for IsRoot.isRooted() showing access of rootResult.result; clarified that DetectionResult.result is a boolean; minor formatting tweaks only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A gentle hop through README's page,
Where code examples now engage,
isRooted() calls shine bright and clear,
No mysteries for readers here,
The result field now understood—
Our documentation's looking good! 📚✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: adding documentation to clarify the isRooted result field in the README.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
Verify each finding against the current code and only fix it if needed.


In `@README.md`:
- Line 99: The README imports the IsRoot symbol from the wrong module name;
update the import statement that references IsRoot so it matches the installed
package scope by changing the module path from "capacitor-is-root" to
"@capgo/capacitor-is-root" wherever the import for IsRoot is used (e.g., the
line that currently reads import { IsRoot } from 'capacitor-is-root';).

Comment thread README.md Outdated
@TorichanCapgo

Copy link
Copy Markdown
Contributor Author

Fixed ✅ Updated the README example import to use in commit 0ba3e9c.

@TorichanCapgo

Copy link
Copy Markdown
Contributor Author

Fixed ✅ Updated the README example import to use "@capgo/capacitor-is-root" in commit 0ba3e9c.

@riderx
riderx merged commit 7424fd0 into Cap-go:main Feb 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants