Skip to content

Commit

Permalink
release 2023.1: updated the release notes and test
Browse files Browse the repository at this point in the history
  • Loading branch information
robyww committed May 1, 2023
1 parent b7bc973 commit df4bee4
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 5 deletions.
6 changes: 3 additions & 3 deletions docs/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@
- [Notes on next version](next-release-details.md)

## Version 2023.1
- 2022.3.0 - (Dec 2022)
- 2022.3.0 - (May 2023)
- docker tag: `latest`, `2022.3`, `2022.3.0`

### _Notes_
#### This release some significant new features and code clean up
#### This release includes some significant new features, existing feature improvements, and code clean up

#### New Features
- TAP Upload: [Firefly-1142](https://github.com/Caltech-IPAC/firefly/pull/1317), [Firefly-1148](https://github.com/Caltech-IPAC/firefly/pull/1331), [Firefly-1189](https://github.com/Caltech-IPAC/firefly/pull/1337)
- Improve TAP UI: [Firefly-1215](https://github.com/Caltech-IPAC/firefly/pull/1354)
- Improved Click to search UI: [Firefly-1152](https://github.com/Caltech-IPAC/firefly/pull/1326)
- Improved Derived columns UI: [Firefly-1153](https://github.com/Caltech-IPAC/firefly/pull/1330)
- Improved Charting and Spectral UI layout: [Firefly-1183](https://github.com/Caltech-IPAC/firefly/pull/1348)
- Improve 3-color selection: [Firefly-1134](https://github.com/Caltech-IPAC/firefly/pull/1310)
- Improved 3-color selection: [Firefly-1134](https://github.com/Caltech-IPAC/firefly/pull/1310)
- UWS support: [Firefly-1128](https://github.com/Caltech-IPAC/firefly/pull/1308), [Firefly-1129](https://github.com/Caltech-IPAC/firefly/pull/1319)
- Faster image loading: [Firefly-1190](https://github.com/Caltech-IPAC/firefly/pull/1338)
- Table of loaded image available in pinned image section: [Firefly-1081](https://github.com/Caltech-IPAC/firefly/pull/1344)
Expand Down
22 changes: 20 additions & 2 deletions src/firefly/js/util/__tests__/VOAnalyzer-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,29 @@ describe('VOAnalyzer:', () => {
expect(actual.lonCol).toEqual('ra1');
expect(actual.latCol).toEqual('dec1');

// test ra_obj/dec_obj
table.tableData.columns = [
{name: 'ra_obj'},
{name: 'dec_obj'},
];
actual = findTableCenterColumns(table);
expect(actual).toBeTruthy();
expect(actual.lonCol).toEqual('ra_obj');
expect(actual.latCol).toEqual('dec_obj');


// test fail
table.tableData.columns = [
{name: 'my_ra_unrecognized'},
{name: 'my_dec_unrecognized'}
];
actual = findTableCenterColumns(table);
expect(actual).toBeFalsy();

// test fail
table.tableData.columns = [
{name: 'ra_unrecognized'},
{name: 'dec_unrecognized'}
{name: 'rastuff'},
{name: 'decstuff'}
];
actual = findTableCenterColumns(table);
expect(actual).toBeFalsy();
Expand Down

0 comments on commit df4bee4

Please sign in to comment.