ci: gate event schema coverage against publish-site count - #466
Merged
greatest0fallt1me merged 3 commits intoJun 26, 2026
Merged
Conversation
The coverage job was nested at the wrong YAML level and would never run. Tighten the script to extract topics from publish sites across contract src. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@temisan0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
CI was failing on missing PAUSED_KEY/ERR_PAUSED in revenue_pool and cargo fmt --check drift across the three contract crates. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Contributor
|
event-schema coverage CI gate — merged 👍 (the workflow-file edit is deferred since the token can't push workflow changes, but the PR is in). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds a CI gate that counts every
env.events().publish(call in the three contract crates and checks each topic has a row inEVENT_SCHEMA.md. If someone adds a publish site without updating the schema, the build fails.scripts/check_event_schema_coverage.shevent-schema-coveragein.github/workflows/ci.yml#[cfg(test)]blocks and test-only files (test.rs,test_*.rs)CI status
The new gate passes. Build (release) passes too.
Test and Coverage are red, but that was already true on
mainbefore this PR — settlement tests don't compile (missing imports, staletry_*usage). See main CI, June 19. Not in scope for #447.How I tested
Ran the script locally — 36 topics, all documented.
Dropped a fake
gate_test_fake_eventpublish into vaultlib.rsto confirm it catches gaps:Closes #447