feat(revenue-pool): replace string panics with RevenuePoolError contract error - #460
Merged
greatest0fallt1me merged 2 commits intoJun 26, 2026
Conversation
…acterror (CalloraOrg#423) Add RevenuePoolError enum with 21 typed variants (contracterror, repr(u32)). Replace all panic!() and .expect() calls with env.panic_with_error(RevenuePoolError::*). Add missing PAUSED_KEY constant. Remove obsolete ERR_* string constants. Fix test.rs broken duplicate section. Convert should_panic tests to try_* + is_err(). Run cargo fmt across workspace.
|
@omosvico Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ool) to match stable rustfmt 1.8.0
Contributor
|
RevenuePoolError typed errors — merged 👍 reconciled onto current main where it overlapped already-merged error work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RevenuePoolError enum with 21 typed variants (contracterror, repr(u32)). Replace all panic!() and .expect() calls with env.panic_with_error(RevenuePoolError::). Add missing PAUSED_KEY constant. Remove obsolete ERR_ string constants. Fix test.rs broken duplicate section. Convert should_panic tests to try_* + is_err(). Run cargo fmt across workspace.
closes: #423