Skip to content

audit(vault): replace remaining string panics with VaultError variants #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatest0fallt1me merged 5 commits into from
Jun 26, 2026
Merged

audit(vault): replace remaining string panics with VaultError variants #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07fec4a
audit(vault): replace remaining string panics with VaultError variants
Kingvic300 Jun 25, 2026
f941f23
fix(revenue-pool): restore PAUSED_KEY/ERR_PAUSED constants dropped in…
Kingvic300 Jun 25, 2026
890f453
fix(settlement): fix test suite for current soroban-sdk API, restore …
Kingvic300 Jun 25, 2026
5c74251
fix(vault): restore validation checks dropped during panic-to-error r…
Kingvic300 Jun 25, 2026
d9a300d
fix(vault): update test suite for typed VaultError returns and real-w…
Kingvic300 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion contracts/revenue_pool/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ const ADMIN_KEY: &str = "admin";
const PENDING_ADMIN_KEY: &str = "pending_admin";
const USDC_KEY: &str = "usdc";
const MAX_DISTRIBUTE_KEY: &str = "max_distribute";
const PAUSED_KEY: &str = "Paused";
const ERR_AMOUNT_NOT_POSITIVE: &str = "amount must be positive";
const ERR_AMOUNT_EXCEEDS_MAX_DISTRIBUTE: &str = "amount exceeds max_distribute";
const ERR_UNAUTHORIZED: &str = "unauthorized: caller is not admin";
const ERR_INSUFFICIENT_BALANCE: &str = "insufficient USDC balance";
const ERR_NOT_INITIALIZED: &str = "revenue pool not initialized";
const ERR_DUPLICATE_RECIPIENT: &str = "duplicate recipient in batch";
const ERR_PAUSED: &str = "revenue pool is paused";
const VERSION_KEY: &str = "version";

pub const DEFAULT_MAX_DISTRIBUTE: i128 = i128::MAX;
Expand Down Expand Up @@ -517,7 +519,9 @@ impl RevenuePool {
}

// Extend TTL before executing transfers.
env.storage().instance().extend_ttl(LIFETIME_THRESHOLD, BUMP_AMOUNT);
env.storage()
.instance()
.extend_ttl(LIFETIME_THRESHOLD, BUMP_AMOUNT);

// Phase 3: Execution — all validation passed, perform transfers.
// Soroban's transaction model guarantees that if any transfer fails,
Expand Down
Loading
Loading