Skip to content

test: add batch_deduct event ordering and revert tests - #370

Merged
greatest0fallt1me merged 3 commits into
CalloraOrg:mainfrom
karanjakevin39-collab:task/vault-batch-deduct-event-tests
May 27, 2026
Merged

test: add batch_deduct event ordering and revert tests#370
greatest0fallt1me merged 3 commits into
CalloraOrg:mainfrom
karanjakevin39-collab:task/vault-batch-deduct-event-tests

Conversation

@karanjakevin39-collab

Copy link
Copy Markdown
Contributor
  • batch_deduct_events_fire_in_input_order: asserts deduct events are
    emitted in the same sequence as the input Vec items
  • batch_deduct_events_carry_correct_running_balance: asserts each event
    carries the per-item running balance (not the final balance)
  • batch_deduct_max_deduct_violation_at_index_0_reverts_all: violation
    at position 0 reverts the whole batch, no events emitted
  • batch_deduct_max_deduct_violation_at_middle_index_reverts_all: same
    for a violation at a middle index
  • batch_deduct_max_deduct_violation_at_last_index_reverts_all: same
    for a violation at the last index

All 158 tests pass. Closes #346

@drips-wave

drips-wave Bot commented May 27, 2026

Copy link
Copy Markdown

@karanjakevin39-collab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@greatest0fallt1me
greatest0fallt1me merged commit 27b80f3 into CalloraOrg:main May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vault: add batch_deduct event-ordering and partial-failure regression tests

2 participants