chore(contracts): validate settlement address is set before automatic… - #311
Merged
greatest0fallt1me merged 2 commits intoApr 24, 2026
Conversation
… transfers on deduct Closes CalloraOrg#263. - deduct / batch_deduct now panic with "settlement address not set" before any balance mutation when StorageKey::Settlement is absent. This closes the silent loss-of-accounting window where vault balance could decrement with no corresponding on-ledger USDC transfer. - Revenue-pool fallback removed from the deduct path. set_revenue_pool / get_revenue_pool / init revenue_pool parameter retained as informational configuration only. - Added require_settlement() and get_max_deduct() private helpers; get_max_deduct was referenced but undefined prior to this change. - Normalised StorageKey::MetaKey references to StorageKey::Meta so the crate compiles against the canonical enum definition. - Added require_not_paused() to deduct to match the documented pause semantics (is_paused rustdoc and SECURITY invariants). - Updated SECURITY.md, SETTLEMENT_IMPLEMENTATION.md, EVENT_SCHEMA.md, INVARIANTS.md to reflect the strict settlement precondition. Tests: 180/181 passing in callora-vault; the one pre-existing failure (test::owner_can_deposit) is an internally-contradictory test pair on the deposit event schema, unrelated to this change.
|
@Onyedika3d Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263.