Refactor/vault deposit signature - #304
Merged
greatest0fallt1me merged 2 commits intoApr 24, 2026
Merged
Conversation
…ion (owner vs depositor) - Change deposit function parameter from 'caller' to 'depositor' for semantic clarity - Update deposit event to include depositor address as topic 1 - Update documentation in README.md, EVENT_SCHEMA.md, and vault interface JSON - Maintain backward compatibility for external callers while improving internal naming
|
@OsejiFabian Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245
📋 Key Sections
Summary & Rationale - Clear explanation of why the change was needed Technical Changes - Detailed breakdown of code and documentation updates
Security Impact - Assurance that no functional changes were made Testing Strategy - Steps to validate the changes work correctly Files Changed - Complete list of modified files Breaking Changes - Explicitly states "None" for confidence
🎯 Key Points for Reviewers
Zero Breaking Changes - External API completely preserved
Semantic Improvement - depositor vs caller for clarity
Security Benefits - Enhanced audit trails with depositor in events
Complete Documentation - All references updated consistently
📝 Usage
closes#245