feat(vault): deposit flow with auth, token transfer, pause - #294
Merged
greatest0fallt1me merged 3 commits intoApr 23, 2026
Conversation
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Fix unused variable warning in settlement test (third_party shadowed binding)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(vault): deposit flow with auth, token transfer, pause
Closes #224
Changes
Hardened deposit guard ordering: pause → require_auth → amount positivity → authorization → min_deposit → transfer → persist → emit
Fixed event schema: removed caller from topics to match EVENT_SCHEMA.md (topic 0 = Symbol("deposit") only)
Cleaned up stray AllowedDepositors write in set_allowed_depositor
Removed duplicate get_max_deduct definition that blocked compilation
Tests — 155 passing
Unit: owner deposit, allowed depositor deposit, unauthorized rejection, below-minimum, at-minimum boundary, paused vault, balance unchanged on failure, event schema alignment
Property: balance round-trip invariant (100 iterations), unauthorized rejection (100), non-positive amount rejection (100), idempotent depositor management (100)
Security notes
Pause check fires before require_auth — prevents leaking which addresses are authorized during an incident
Transfer-before-persist ensures no internal state mutates if the on-ledger USDC transfer fails
Checked arithmetic on balance update with explicit "balance overflow" panic