Test/vault max balance closes #264 - #291
Merged
greatest0fallt1me merged 2 commits intoApr 23, 2026
Merged
Conversation
|
@ChukwuemekaP1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added explicit max-balance boundary tests across the
Calloracontracts to ensure overflow safety. These tests verify that the system fails safely and deterministically when an operation would push a balance beyond thei128::MAXlimit.Changes
Vault Contract
checked_addlogic indeposit()by setting the balance toi128::MAX - 1and attempting a 2-unit deposit.Revenue Pool Contract
i128::MAX.Settlement Contract
Documentation
<= i128::MAX).Verification
cargo clippypassed with no warnings.callora-vaultto WASM release target.checked_add(...).unwrap()paths correctly trigger transaction reverts on overflow rather than silent wrapping.closes #264