chore(contracts): add cargo test --workspace and include evenue_pool + settlement ( #259) - #285
Merged
greatest0fallt1me merged 2 commits intoApr 23, 2026
Conversation
…+ settlement - ci: use cargo test --workspace in CI to explicitly test all crates - fix(vault): remove duplicate get_max_deduct function (compilation error) - fix(vault): add equire_not_paused guard to �atch_deduct (security) - fix(tests): resolve unused variable, type mismatch, and fuzz pause gaps - docs: update README, SECURITY.md, tarpaulin.toml for workspace coverage All 148 tests pass across vault, settlement, and revenue_pool. cargo fmt, clippy (-D warnings), and cargo test --workspace clean.
|
@felixkamau Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259
chore(contracts):addcargo test --workspaceand includerevenue_pool+settlement(#259)What
Makes CI explicitly test all three workspace crates (
vault,settlement,revenue_pool) withcargo test --workspace, and fixes several bugs uncovered in the process.Changes
CI
cargo test→cargo test --workspacein.github/workflows/ci.ymlto explicitly exercise every crate on every push/PR.Bug Fixes
vaultget_max_deductfunction (caused compilation error)vaultrequire_not_pausedguard tobatch_deductsettlement-D warningsfailure)vaultset_allowed_depositorcall with wrong type (&Address→&Option<Address>)vaultdeduct/batch_deductopsvaultdepositop panicking when random amount exceeds minted USDC reserveDocs
cargo test --workspaceSecurity Notes
Test Output
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --workspace