Feature/vault revenue routing Closes #230 - #281
Merged
greatest0fallt1me merged 3 commits intoApr 23, 2026
Merged
Conversation
- Add require_routing_configured() to enforce at least one routing address - Update deduct() and batch_deduct() to validate routing before execution - Add address validation to set_revenue_pool() and set_settlement() - Prevent self-referential routing (vault cannot route to itself) - Add comprehensive Rust documentation to routing setters - Add 12 new routing configuration and behavior tests - Update existing tests to include revenue_pool configuration - Implement Option A safety: reject operations if routing unset - Add routing priority tests (settlement > revenue_pool) - Add edge case tests (same address for both roles, multiple updates) Breaking change: deduct/batch_deduct now fail if no routing configured
- Add require_routing_configured() to enforce at least one routing address - Update deduct() and batch_deduct() to validate routing before execution - Add address validation to set_revenue_pool() and set_settlement() - Prevent self-referential routing (vault cannot route to itself) - Add comprehensive Rust documentation to routing setters - Add 12 new routing configuration and behavior tests - Update existing tests to include revenue_pool configuration - Implement Option A safety: reject operations if routing unset - Add routing priority tests (settlement > revenue_pool) - Add edge case tests (same address for both roles, multiple updates) - Update SECURITY.md with routing validation and safety requirements - Update SETTLEMENT_IMPLEMENTATION.md with routing configuration docs - Fix fuzz tests to handle paused state and routing configuration - Achieve 96.03% code coverage (≥95% requirement met) - All 168 tests pass, zero clippy warnings, WASM builds successfully Breaking change: deduct/batch_deduct now fail if no routing configured
|
@ChukwuemekaP1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements configurable routing addresses for vault revenue flows with comprehensive validation, safety guarantees, and full test coverage.
What's Changed
Core Features:
require_routing_configured()to enforce at least one routing address before deduct operationsset_revenue_pool()andset_settlement()with address validation (prevents self-routing)Safety Improvements:
Tests & Coverage:
Documentation:
Validation
Closes #230