fix(vault): enforce checked arithmetic on balance changes - #279
Merged
greatest0fallt1me merged 2 commits intoApr 23, 2026
Conversation
- Remove duplicate get_max_deduct() definition - Replace bare .unwrap() on checked operations with descriptive panics - Add batch_deduct require_not_paused guard (was missing unlike deduct) - Fix fuzz run_sequence pause handling for deduct and batch_deduct ops - Add withdraw_near_i128_max_succeeds and batch_deduct_to_zero_succeeds tests - Fix unused-variable warning in settlement test (dead third_party binding) - Fix type mismatch in vault test (pass Some(addr) to set_allowed_depositor) - Document i128::MAX boundary behavior in SECURITY.md (Issue #233)
|
@anoncon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_max_deduct()definition (compile fix)require_not_pausedtobatch_deduct(was missing unlikededuct).unwrap()on alli128balance mutations with descriptive panicsrun_sequenceto handle pause state for deduct/batch_deduct opswithdraw_near_i128_max_succeedsandbatch_deduct_to_zero_succeedsboundary testsi128::MAXbehavior inSECURITY.mdCloses #233