chore(contracts): add and view docs + tests closes #262 - #277
Merged
greatest0fallt1me merged 3 commits intoApr 23, 2026
Conversation
|
@ChukwuemekaP1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…zz test stability - Add missing require_not_paused check to batch_deduct function - Fix fuzz tests to handle paused state correctly for deduct and batch_deduct - Cap deposit amounts in fuzz tests to prevent USDC balance overflow - Increase deposit reserve to 10 trillion for large max_deduct scenarios - Remove duplicate unused third_party variable in settlement tests - All 227 tests now pass (157 vault, 47 settlement, 23 revenue_pool) - Coverage maintained at 95.76% (≥95% requirement met) - Zero clippy warnings across all contracts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Issues Resolved
Problem: The Vault module had
get_settlement()andget_revenue_pool()functions but lacked proper documentation, comprehensive test coverage, and audit-ready safety guarantees.✅ What Was Fixed
Missing Documentation
Insufficient Test Coverage
Pre-existing Bugs
get_max_deduct()function definitionset_allowed_depositor()Git Push Permission Issue
📊 Results
closes #262