fix: Security: add checklist section for authorized caller role management in vault - #276
Merged
greatest0fallt1me merged 1 commit intoApr 23, 2026
Conversation
…or authorized caller role management in vault
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new "Authorized Caller Role Management" checklist section to
SECURITY.md, placed directly after the existing "Admin Transfer" section so role-management controls are grouped together.The new section documents the vault's
authorized_callerrole (stored inVaultMeta, set viaset_authorized_caller) and provides an audit-friendly checklist covering:meta.owner.require_auth()set_auth_callerevent for off-chain monitoringdeduct/batch_deductNonestate (no privilege fallback)A "Security note" blockquote (matching the style of the existing Revenue Routing section) summarizes the threat model: the role can spend balance within
max_deductso rotation must be prompt if the off-chain driver key is compromised; rotation is atomic, owner-only, and observable via the emitted event.Changes are documentation-only, minimal, and reviewer-friendly.
closes #272