This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
update slap #64
Closed
update slap #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrangeEcho
suggested changes
Jan 5, 2022
Robin5605
reviewed
Jan 5, 2022
| url="https://api.waifu.pics/sfw/slap" | ||
| ) as resp: | ||
| await ctx.send( | ||
| embed=discord.Embed( |
There was a problem hiding this comment.
Should be disnake.Embed(...) to maintain consistency
Robin5605
reviewed
Jan 5, 2022
| await ctx.send(embed=embed2) | ||
| async def slap(self, ctx, member: Member = None): | ||
| """slap someone""" | ||
| async with self.bot.session.get( |
There was a problem hiding this comment.
The bot instance doesn't have a session variable like @Yat-o pointed out, though we are working on reusing the aiohttp.ClientSession() instance.
Robin5605
suggested changes
Jan 5, 2022
Pandabweer
requested review from
Pandabweer
and removed request for
Pandabweer
|
Denied PR because of lack of attention, i suggest finishing on PR before opening a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.