Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

GIF Commands (like slap and those) #68

Open
osam7a opened this issue Jan 6, 2022 · 12 comments
Open

GIF Commands (like slap and those) #68

osam7a opened this issue Jan 6, 2022 · 12 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@osam7a
Copy link
Contributor

osam7a commented Jan 6, 2022

I Have an api key on GIPHY.com and i can get gifs from there, can you maybe put my key in the hidden.py and i will make the commands?

@StrangeEcho
Copy link
Collaborator

Negative comrade. To stay consistent with all of our commands we will use the same exact API. Atleast for the Roleplay commands that are featured in the Fun cog. I believe we established on https://waifu.pics as the main choice. Requires no api key and very rare that you will get 429d

@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

but that isnt even a gif website?
am talking about something different than this

@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

or maybe i can just make 1 "gif" command that gets a gif ffrom the query

@StrangeEcho
Copy link
Collaborator

Your purpose in this issue was talking about using giphy for commands like slap and kiss and whatnot. As it is, waifu.pics has a gif endpoint for most of our Roleplay commands. See here for reference https://waifu.pics/docs

@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

i didnt mean just those, i meant to use giphy to get gifs (from queries or randomly)

@StrangeEcho
Copy link
Collaborator

I only assumed so, since that seemed that was the scope of your issue title. Elaborate more on this command you're proposing. Break down how it would work as well.

@StrangeEcho StrangeEcho reopened this Jan 6, 2022
@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

so probably you know giphy its a gif website that has ALOOTTT of gifs, i can make commands like maybe jarvide gif random this would get a random gif or jarvide gif <some topic> would give a random gif of this topic or any other commands, i already made an app at there dashboard and i have a key

@StrangeEcho
Copy link
Collaborator

Interesting. So you won’t be using giphy for Jarvide's commands. If so, your idea is fine. Just submit a PR. And follow the workflow procedure I touched on in #announcements.

@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

okay, can you add my api key in hidden.py

@Pandabweer
Copy link
Collaborator

Any update on how this is going to get implemented?

@Pandabweer Pandabweer added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jan 6, 2022
@Pandabweer Pandabweer linked a pull request Jan 6, 2022 that will close this issue
@osam7a
Copy link
Contributor Author

osam7a commented Jan 6, 2022

just waiting for caeden to put my key in hidden.py

@wasi-master
Copy link

wasi-master commented Mar 3, 2022

Why not just use a .env file for API tokens, that's the industry standard. Python files should be avoided imo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants