Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickling support #1762

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Pickling support #1762

merged 8 commits into from
Feb 14, 2025

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Feb 5, 2025

closes #1634

  • Vector
  • Plane
  • Location
  • Color
  • Shape
  • Matrix
  • Tests

@adam-urbanczyk adam-urbanczyk marked this pull request as draft February 5, 2025 18:24
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (f13f607) to head (e18e55c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   95.33%   95.36%   +0.02%     
==========================================
  Files          28       28              
  Lines        6841     6885      +44     
  Branches     1025     1027       +2     
==========================================
+ Hits         6522     6566      +44     
  Misses        194      194              
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review February 5, 2025 19:16
@jmwright
Copy link
Member

jmwright commented Feb 6, 2025

@adam-urbanczyk this would fulfill the request in #973 as well, correct?

@adam-urbanczyk
Copy link
Member Author

I suppose, though serialization was already implemented.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk , I do not see any issues.

@adam-urbanczyk adam-urbanczyk merged commit 9e47392 into master Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pickling support
3 participants