HMC sampler#449
Draft
furibec wants to merge 7 commits into
Draft
Conversation
Collaborator
Author
Collaborator
Author
Collaborator
Author
|
I believe the samplers are working as expected and they are also in CUQIpy format. Nevertheless, some test are failing due to the changes I did in NUTS. I hope someone can take it from here @jakobsj |
Contributor
|
Thank you very much @furibec for adding your HMC sampler, the fixes as well as a demo validating the implementation, that is most helpful! I cannot promise when we'll be able to look at this but I hope it will be soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


_hmc.pycontained the NUTS implementation, so I renamed it to_nuts.pyneg_Hamiltonianfunction and added some explanation, improved epsilon adaptation functions, and a few changes in theBuildTreewhile I was checking everything looks correct.