CHERI TGOT TLS #773
Draft
CHERI TGOT TLS #773
+1,225
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrtc27
commented
Jul 12, 2025
jrtc27
commented
- [BinaryFormat][llvm-readobj] Add CHERI TGOT segment and dynamic entry types
- [MC] Add a new -(no-)cheri-tgot-tls flag
- [Target] Adapt TargetMachine::getTLSModel for CHERI TGOT
- [RISCV][MC] Add support for CHERI TGOT relocations and assembly syntax
- [AMDGPU][CodeGen] Add a TGOT PseudoSourceValue
- [RISCV] Add CodeGen support for CHERI TGOT
- [clang][RISCV] Add -(no-)cheri-tgot-tls flag
- [ELF] Support CHERI TGOT TLS
- [BinaryFormat] Add RISC-V-specific CHERI TGOT dynamic entry types
- [llvm-objdump][llvm-readobj] Add support for dumping __tgot_cap_relocs
- [ELF][RISCV] Support linking CHERI TGOT TLS objects
Support for honouring this in various places will follow in subsequent commits.
The TLS models behave slightly differently for CHERI TGOT, since the access being performed is always to this module's TGOT, and so whether the symbol is local or not never matters. Local Dynamic is also never used, even if explicitly requested, since by design it violates pointer provenance.
Until we've migrated to proper relative ELF relocations for capabilities we need a special __tgot_cap_relocs alongside .rela.tgot, just as __cap_relocs augments .rela.dyn.
Also fix some style isseus whilst here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.