Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom properties #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mzyil
Copy link

@mzyil mzyil commented Dec 5, 2018

No description provided.

@frvge
Copy link
Contributor

frvge commented Dec 9, 2018

@mzyil , great work! This is a much requested feature.

Could you please have a look at the failing tests? I think with the support for the custom properties, they might be outdated.

Please also try to add a unit test for the detection of the custom properties.

@parak80
Copy link

parak80 commented Dec 10, 2018

Problem solved, there was a build error when i was using only IE css by writing :ms-fullscreen, :root className{}
It needed - before all of this.
Thank you for you help anyway :)

@mzyil
Copy link
Author

mzyil commented Dec 27, 2018

@frvge I'm sorry but we moved on from this package, and I don't have much time in my hands to continue working on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants