add two rules #700
Open
add two rules #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frvge
requested changes
Nov 11, 2017
| CSSLint.addRule({ | ||
|
|
||
| // rule information | ||
| id: "rule-name", |
There was a problem hiding this comment.
Please make the id a bit more descriptive. maybe like rule-name-no-underscore
|
|
||
| // rule information | ||
| id: "rule-name", | ||
| name: "Rule name must concat with -", |
There was a problem hiding this comment.
The name says it should concatenate with a dash, but the test checks that there's no underscore, so there's a mismatch in the description and the actual behavior of the code. I suggest to change the name and desc.
|
|
||
| name: "multi-rules-newline", | ||
|
|
||
| "Multi rules must declear in multi lines": function() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add two rules
1.multi-rules-newline
2.rule-name