Minor improvements to caches and CI #3374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CircleCI test splitting to use test names instead of filenames (documentation was buried deep on this one). This should improve parallel test distribution, especially for browser tests that are all in one file.
aatkin
force-pushed
the
ci-improvements
branch
2 times, most recently
from
a71865f to
54c42eb
Compare
- Renamed kaocha plugins - Write cache statistics to files in target/cache-statistics-plugin instead of stdout, and store as CircleCI artifacts - Write test-ids and split-test-ids to files in target/circleci-parallel-plugin and store as CircleCI artifacts
This was unnecessary part from the beginning, and mainly just interesting while debugging early version of the cache. There is a subtle "bug" regarding config startup: mount is not started before the namespace is loaded. It's not an easy issue to solve, because caches are defined in many different namespaces and initialized using function call.
rems.main was removed at some point as unnecessary require, but it is now used by hooks test, and sometimes Kaocha test runner goes haywire about the missing require.
aatkin
force-pushed
the
ci-improvements
branch
from
54c42eb to
5cf0c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rems.kaocha:--plugin rems.kaocha/circleci-parallel-pluginnow saves its output totarget/circleci-parallel-plugin/test-ids.txtandsplit-test-ids.txt--plugin rems.kaocha/cache-statistics-pluginnow saves its output totarget/cache-statistics-plugin/cache-report.mdCircleCI:
--timings-type=testnameflag to CircleCI test splittingrems.cache::get) as unneeded featureEnsure config is started when callingcache/basic:Should have been obvious, but when db namespaces with caches are loaded, the caches are initialized before config is mounted, and all the dev checks are always falsy.Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability