Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken build #3370

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix broken build #3370

wants to merge 2 commits into from

Conversation

aatkin
Copy link
Collaborator

@aatkin aatkin commented Jan 13, 2025 •
edited
Loading

Fixes #3369

Fixes uberjar build issues with user simulator feature:

  1. Moved etaoin dependency from dev dependencies to main dependencies, as it's required by the user simulator
  2. Moved test data setup from browser-test-util to test-browser (due to additional dependency from user-simulator -> browser-test-util -> api.testing -> peridot.multipart)

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue

aatkin added 2 commits January 13, 2025 14:56
@aatkin
fix: move etaoin dependency to main dependencies for user simulator
fac296a
@aatkin
refactor: move test data setup from browser-test-util to test-browser
fca43e3 
Move test data setup to make browser-test-util more generic and to avoid requiring additional test libraries in the namespace. This helps with the user simulator feature which needs only the browser automation functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uberjar build fails
1 participant
@aatkin