feat: Add a basic diesel::Instrumentation impl #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a very basic implementation for using `tracing` with diesel's `Instrumentation` trait. This implementation just maps `diesel` events directly to `tracing` without much extra information provided beyond that in the events themselves. In order to bring this in line with the rest of the crate I think there are a few more additions that are required before a release: - Saving the url used during connection to be included in other events. - Using opentelemetry semantic conventions for event values. - Usage documentation and recommendations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a very basic implementation for using
tracingwith diesel'sInstrumentationtrait. This implementation just mapsdieselevents directly totracingwithout much extra information provided beyond that in the events themselves.In order to bring this in line with the rest of the crate I think there are a few more additions that are required before a release: