linearize unsupported constraints (e.g. pow and mod) #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
there was no final else case for certain constraint types e.g. table constraint; added an initial skip block for all supported types. Maybe this should be separate? locally I have no failing tests either way, so I'm confused why the CI is failing here |
Collaborator
|
Hmm I'm hesitant for throwing the entire model through linearize... It will add a lot of overhead that is not required. The proper fix is to treat div and mod as global constraints instead, and provide a suitable decomposition for them. (This can just be the linear one that we have already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #795